Skip to content

Directive doesn't need to be terminal anymore#147

Open
gabegorelick wants to merge 1 commit into
rubenv:masterfrom
gabegorelick:no-terminal
Open

Directive doesn't need to be terminal anymore#147
gabegorelick wants to merge 1 commit into
rubenv:masterfrom
gabegorelick:no-terminal

Conversation

@gabegorelick

Copy link
Copy Markdown
Collaborator

See #132

@rubenv

rubenv commented Dec 8, 2014

Copy link
Copy Markdown
Owner

One thing I'm wondering about: does terminal: true prevent the body from being parsed?

And if we turn it off: will it be parsed / compiled?

In the directive, we do $animate.leave(oldContents); immediately, so if we can avoid Angular.JS from processing the contents of the directive, all the better.

But maybe this is covered by priority? I'm not intimate with the deep internals of the Angular.JS compile loop to properly know the true impact of this.

@gabegorelick

Copy link
Copy Markdown
Collaborator Author

This is why I didn't directly commit this patch ;)

I believe priority and terminal only relate to what happens when there are multiple directives on the same element. But I'm not an expert either.

@gabegorelick

Copy link
Copy Markdown
Collaborator Author

This is the best explanation I've seen: http://stackoverflow.com/a/15266968

@princed

princed commented Jul 17, 2015

Copy link
Copy Markdown

@rubenv @gabegorelick Is it going to to be merged? We've bumped into this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants